Verdict
Amber-red: memorable idea, but too tight as a 10-day first-China route if Zhangjiajie must feel worthwhile.
This is a sample first reply for a traveler trying to fit Beijing, Xi’an, Zhangjiajie, and Shanghai into 10 days. It shows the level of concrete judgement ChinaVoyage aims to give before bookings harden.

Amber-red: memorable idea, but too tight as a 10-day first-China route if Zhangjiajie must feel worthwhile.
At least 2 full mountain days, 3 nights when possible, and a cleaner arrival/departure pattern around Wulingyuan or downtown Zhangjiajie.
Do not lock Zhangjiajie hotel nights, internal flights, or park tickets until the scenic priority and walking comfort are clear.
Either extend to 12–14 days, or keep 10 days and simplify: Beijing + Zhangjiajie + Shanghai, or choose Guilin/Yangshuo as the softer scenic anchor.
The route spends real money and energy reaching the mountains, but protects only one weather-sensitive sightseeing day.
The traveler remembers airports, luggage, hotel moves, and early departures instead of a calmer scenic anchor.
Flights and hotels look bookable, but park sequence, entrance area, walking comfort, and weather buffer are not solved yet.
Many first-China travelers try to keep the classic cities and add Zhangjiajie as if the mountains cost only one extra box on the map.
What gets underestimated is not only the flight or ticket, but the weather sensitivity, hotel placement, walking load, and the emotional cost of rushed scenic time.
A premium route often feels better when it protects one dramatic reason for the trip instead of forcing every saved place into one loop.
Your route can work emotionally — classic cities plus one dramatic scenic anchor — but Zhangjiajie is currently under-protected.
Before booking, decide whether Zhangjiajie is the main reason for the trip or only a “nice-to-have” add-on. If it is the main reason, give it more nights. If comfort matters more, Guilin/Yangshuo may fit 10 days better.
The next useful details are: travel month, arrival/departure cities, walking comfort, whether parents or children are traveling, and whether scenery or city culture matters more.